linux-kernel - Re: [PATCH v3 0/5] staging: et131x: patches for et131x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAb+SYbgNBhyp7-+OEuPtQfSDg=cMNF_zpqx15K5FygOmHWQ1w@mail.gmail.com>
Date:	Fri, 22 Nov 2013 10:12:41 +0800
From:	ZHAO Gang <gamerh2o@...il.com>
To:	Mark Einon <mark.einon@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>, devel@...verdev.osuosl.org
Subject: Re: [PATCH v3 0/5] staging: et131x: patches for et131x driver

On Fri, Nov 22, 2013 at 5:18 AM, Mark Einon <mark.einon@...il.com> wrote:
> On Wed, Nov 20, 2013 at 03:53:50PM +0800, ZHAO Gang wrote:
>> This patch set should apply to current staging-next tree
>>
>> ZHAO Gang (5):
>>   staging: et131x: clean up code
>>   staging: et131x: drop packet when error occurs in et131x_tx
>>   staging: et131x: stop read when hit max delay in et131x_phy_mii_read
>>   staging: et131x: remove spinlock adapter->lock
>>   staging: et131x: update TODO list
>>
>>  drivers/staging/et131x/README   |   5 -
>>  drivers/staging/et131x/et131x.c | 301 +++++++++++++++++-----------------------
>>  2 files changed, 127 insertions(+), 179 deletions(-)
>>
>> --
>
> Hi Zhao,
>
> Thanks for the patches. A few pointers for the future:
>
> - Use scripts/get_maintainer.pl to discover to which mailing lists /
> maintainers patches should be sent. I've cc'd devel@...verdev.osuosl.org
> which was missing from your original submission.

I will add it to cc list next time.

>
> - Please don't roll up patches you've previously sent into newer
> patchsets, even if they haven't been applied by the tree maintainer
> yet. This just means that the same lines of code get reviewed twice,
> wasting the reviewer's time.

Greg also told me this problem, I will not do this any more.

>
> Cheers,
>
> Mark
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/