linux-kernel - Re: [PATCH 1/3] proc: change do_task_stat() to use while_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANMivWaUUH-gncZxA6RjcavPx-iFc8hDHxErzgVdAzTnnL3r+A@mail.gmail.com>
Date:	Fri, 22 Nov 2013 12:15:57 -0800
From:	Sameer Nanda <snanda@...omium.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Michal Hocko <mhocko@...e.cz>,
	Sergey Dyasly <dserrg@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] proc: change do_task_stat() to use while_each_thread()

On Fri, Nov 22, 2013 at 11:18 AM, Oleg Nesterov <oleg@...hat.com> wrote:
> do_task_stat() can use while_each_thread(), no changes in
> the compiled code.
>
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>
Reviewed-by: Sameer Nanda <snanda@...omium.org>

> ---
>  fs/proc/array.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/proc/array.c b/fs/proc/array.c
> index c995807..c59e74f 100644
> --- a/fs/proc/array.c
> +++ b/fs/proc/array.c
> @@ -442,8 +442,7 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns,
>                                 min_flt += t->min_flt;
>                                 maj_flt += t->maj_flt;
>                                 gtime += task_gtime(t);
> -                               t = next_thread(t);
> -                       } while (t != task);
> +                       } while_each_thread(task, t);
>
>                         min_flt += sig->min_flt;
>                         maj_flt += sig->maj_flt;
> --
> 1.5.5.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/