linux-kernel - Re: [PATCH] Staging:comedi:pcmmio Fixed a printk format in debug section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131123172315.GB8405@kroah.com>
Date:	Sat, 23 Nov 2013 09:23:15 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Abhishek Sudhakaran <itzurabhi@...il.com>
Cc:	abbotti@....co.uk, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging:comedi:pcmmio Fixed a printk format in debug
 section

On Sat, Nov 23, 2013 at 05:05:32PM +0530, Abhishek Sudhakaran wrote:
> Fixed a printk statement in the debug section
> where the string terminator was misplaced.
> 
> Signed-off-by: Abhishek Sudhakaran <itzurabhi@...il.com>
> ---
>  drivers/staging/comedi/drivers/pcmmio.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/pcmmio.c b/drivers/staging/comedi/drivers/pcmmio.c
> index 14cee3a..bc1f44c 100644
> --- a/drivers/staging/comedi/drivers/pcmmio.c
> +++ b/drivers/staging/comedi/drivers/pcmmio.c
> @@ -274,7 +274,7 @@ static int pcmmio_dio_insn_bits(struct comedi_device *dev,
>  #ifdef DAMMIT_ITS_BROKEN
>  		/* DEBUG */
>  		printk
> -		    (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x,"
> +		    (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x",
>  		     " data_in %02x ", byte_no, (unsigned)write_mask_byte,
>  		     (unsigned)data_byte, offset, ioaddr, (unsigned)byte);

Did you build this patch?  I think the original code is correct, and
your change will cause an error, right?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/