linux-kernel - Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201311231857.47104.arnd@arndb.de>
Date:	Sat, 23 Nov 2013 18:57:46 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	"ivan.khoronzhuk" <ivan.khoronzhuk@...com>,
	Santosh Shilimkar <santosh.shilimkar@...com>, wim@...ana.be,
	nsekhar@...com, linux-watchdog@...r.kernel.org,
	devicetree@...r.kernel.org, mark.rutland@....com,
	pawel.moll@....com, swarren@...dotorg.org,
	ijc+devicetree@...lion.org.uk, galak@...nel.crashing.org,
	rob.herring@...xeda.com, linux-kernel@...r.kernel.org,
	grant.likely@...aro.org
Subject: Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property

On Wednesday 06 November 2013, ivan.khoronzhuk wrote:
> @@ -7,6 +7,10 @@ Required properties:
>  
>  - reg : Should contain WDT registers location and length
>  
> +- clocks: phandle reference to the controller clock.
> +         Required only for Keystone arch.
> +         See clock-bindings.txt
> +
>  Optional properties:
>  
>  - timeout-sec:         Contains the watchdog timeout in seconds

I think it should really be listed under "Optional properties" and the
reference to Keystone removed. Note how the binding would need
to change otherwise if another platform started to use the clock, which
is a little silly.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/