linux-kernel - Re: [tip:sched/urgent] sched: Check sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 Nov 2013 19:53:01 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	srikar@...ux.vnet.ibm.com, Thomas Gleixner <tglx@...utronix.de>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:sched/urgent] sched: Check sched_domain before computing
 group power

On Fri, Nov 22, 2013 at 09:00:54PM -0800, Yinghai Lu wrote:
> On Fri, Nov 22, 2013 at 4:07 AM, Peter Zijlstra <peterz@...radead.org> wrote:
> > And I suppose a kernel before
> >
> >   863bffc80898 ("sched/fair: Fix group power_orig computation")
> >
> > work fine, eh?
> >
> > I'll further assume that your RIP points to:
> >
> >         sds.avg_load = (SCHED_POWER_SCALE * sds.total_load) / sds.total_pwr;
> >
> > indicating that sds.total_pwr := 0.
> >
> > update_sd_lb_stats() computes it like:
> >
> >                 sds->total_pwr += sgs->group_power;
> >
> > which comes out of update_sg_lb_stats() like:
> >
> >         sgs->group_power = group->sgp->power;
> >
> > Which we compute in update_group_power() similarly to how we did before
> > 863bffc80898.
> >
> > Which leaves me a bit puzzled.
> 
> Hi,
> for linus tree i need to revert commit-863bffc.
>    commit-863bffc
> 
> for linus tree + sched/urgent, I need to revert
>    commit-42eb088
>    commit-9abf24d
>    commit-863bffc
> .
> If only revert commit-42eb088, still have problem.
> if only revert  commit-9abf24d, commit-863bffc, still have problem.
> 
> Assume you need to dump sched/urgent,
> and revert commit-863bffc directly from Linus's tree.

That doesn't answer any of the questions above and only raises more
questions.

I also will not revert until a little later, I really need to understand
this. My wsm-ep system boots just fine, so there's something funny
somewhere.

I also cannot see the difference between 863bffc^1 and 9abf24d.

Also, you mentioning 42eb088 is new; what does that have to do with
anything? You cannot revert that without also reverting 37dc6b50cee9,
but you don't mention that commit at all.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/