| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131123004334.GJ10023@atomide.com>
Date: Fri, 22 Nov 2013 16:43:35 -0800
From: Tony Lindgren <tony@...mide.com>
To: Grant Likely <grant.likely@...aro.org>,
Rob Herring <rob.herring@...xeda.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: [PATCH] of/platform: Fix no irq domain found errors when
populating interrupts
Currently we get the following kind of errors if we try to use
interrupt phandles to irqchips that have not yet initialized:
irq: no irq domain found for /ocp/pinmux@...02030 !
WARNING: CPU: 0 PID: 1 at drivers/of/platform.c:171 of_device_alloc+0x144/0x184()
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.12.0-00038-g42a9708 #1012
(show_stack+0x14/0x1c)
(dump_stack+0x6c/0xa0)
(warn_slowpath_common+0x64/0x84)
(warn_slowpath_null+0x1c/0x24)
(of_device_alloc+0x144/0x184)
(of_platform_device_create_pdata+0x44/0x9c)
(of_platform_bus_create+0xd0/0x170)
(of_platform_bus_create+0x12c/0x170)
(of_platform_populate+0x60/0x98)
...
This is because we're wrongly trying to populate resources that are not
yet available. It's perfectly valid to create irqchips dynamically,
so let's fix up the issue by populating the interrupt resources based
on a notifier call instead.
Signed-off-by: Tony Lindgren <tony@...mide.com>
---
Rob & Grant, care to merge this for the -rc if this looks OK to you?
These happen for example when using interrupts-extended for omap
wake-up interrupts where the irq domain is created by pinctrl-single.c
at module_init time.
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -130,6 +130,56 @@ void of_device_make_bus_id(struct device *dev)
dev_set_name(dev, "%s.%d", node->name, magic - 1);
}
+/*
+ * The device interrupts are not necessarily available for all
+ * irqdomains initially so we need to populate them using a
+ * notifier.
+ */
+static int of_device_resource_notify(struct notifier_block *nb,
+ unsigned long event, void *dev)
+{
+ struct platform_device *pdev = to_platform_device(dev);
+ struct device_node *np = pdev->dev.of_node;
+ struct resource *res = pdev->resource;
+ struct resource *irqr = NULL;
+ int num_irq, i, found = 0;
+
+ if (event != BUS_NOTIFY_BIND_DRIVER)
+ return 0;
+
+ if (!np)
+ goto out;
+
+ num_irq = of_irq_count(np);
+ if (!num_irq)
+ goto out;
+
+ for (i = 0; i < pdev->num_resources; i++, res++) {
+ if (res->flags != IORESOURCE_IRQ ||
+ res->start != -EPROBE_DEFER ||
+ res->end != -EPROBE_DEFER)
+ continue;
+
+ if (!irqr)
+ irqr = res;
+ found++;
+ }
+
+ if (!found)
+ goto out;
+
+ if (found != num_irq) {
+ dev_WARN(dev, "error populating irq resources: %i != %i\n",
+ found, num_irq);
+ goto out;
+ }
+
+ WARN_ON(of_irq_to_resource_table(np, irqr, num_irq) != num_irq);
+
+out:
+ return NOTIFY_DONE;
+}
+
/**
* of_device_alloc - Allocate and initialize an of_device
* @np: device node to assign to device
@@ -168,7 +218,13 @@ struct platform_device *of_device_alloc(struct device_node *np,
rc = of_address_to_resource(np, i, res);
WARN_ON(rc);
}
- WARN_ON(of_irq_to_resource_table(np, res, num_irq) != num_irq);
+
+ /* See of_device_resource_notify for populating interrupts */
+ for (i = 0; i < num_irq; i++, res++) {
+ res->flags = IORESOURCE_IRQ;
+ res->start = -EPROBE_DEFER;
+ res->end = -EPROBE_DEFER;
+ }
}
dev->dev.of_node = of_node_get(np);
@@ -447,6 +503,8 @@ int of_platform_bus_probe(struct device_node *root,
}
EXPORT_SYMBOL(of_platform_bus_probe);
+static struct notifier_block resource_nb;
+
/**
* of_platform_populate() - Populate platform_devices from device tree data
* @root: parent of the first level to probe or NULL for the root of the tree
@@ -478,6 +536,11 @@ int of_platform_populate(struct device_node *root,
if (!root)
return -EINVAL;
+ if (!resource_nb.notifier_call) {
+ resource_nb.notifier_call = of_device_resource_notify,
+ bus_register_notifier(&platform_bus_type, &resource_nb);
+ }
+
for_each_child_of_node(root, child) {
rc = of_platform_bus_create(child, matches, lookup, parent, true);
if (rc)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists