linux-kernel - Re: [PATCH] n_tty: Fix 4096-byte canonical reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131124003859.06728df9@alan.etchedpixels.co.uk>
Date:	Sun, 24 Nov 2013 00:38:59 +0000
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Peter Hurley <peter@...leysoftware.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, <stable@...r.kernel.org>
Subject: Re: [PATCH] n_tty: Fix 4096-byte canonical reads

On Fri, 22 Nov 2013 07:16:25 -0500
Peter Hurley <peter@...leysoftware.com> wrote:

> Although the maximum allowable canonical line is specified to
> be 255 bytes (MAX_CANON), the practical limit has actually been
> the size of the line discipline read buffer (N_TTY_BUF_SIZE == 4096).

Looks good. MAX_CANON in SVID and POSIX is a guarantee that you'll be
able to edit that may characters into a line. What happens beyond
MAX_CANON is implementation defined and msotly it seems interpreted as
"you may get more" - ie MAX_CANON is a minimum line guarantee.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/