linux-kernel - Re: [PATCH V2 0/7] Staging: comedi: fix coding style issues in unioxx5.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <529322B2.4090702@mev.co.uk>
Date:	Mon, 25 Nov 2013 10:13:06 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Conrad Gomes <conrad.s.j.gomes@...il.com>,
	Ian Abbott <ian.abbott@....co.uk>,
	"hsweeten@...ionengravers.com" <hsweeten@...ionengravers.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"joe@...ches.com" <joe@...ches.com>
CC:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 0/7] Staging: comedi: fix coding style issues in unioxx5.c

On 2013-11-21 19:57, Conrad Gomes wrote:
> This series contains various fixes to coding style issues in unioxx5.c
> found by checkpatch.pl and due to the usage of pr_err instead of the
> preferred dev_err type functions for device drivers.
>
> Conrad Gomes (7):
>    Staging: comedi: fix line over 80 character warning in unioxx5.c
>    Staging: comedi: fix line over 80 character warning in unioxx5.c
>    Staging: comedi: change printk to dev_err/dev_dbg in unioxx5.c
>    Staging: comedi: change pr_err to dev_err in __unioxx5_analog_read
>    Staging: comedi: change pr_err to dev_err in __unioxx5_digital_write
>    Staging: comedi: change pr_err to dev_err in __unioxx5_analog_write
>    Staging: comedi: remove MACRO pr_fmt in unioxx5.c
>
>   drivers/staging/comedi/drivers/unioxx5.c |   50 ++++++++++++++++++------------
>   1 file changed, 31 insertions(+), 19 deletions(-)

Looks okay!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/