linux-kernel - Re: [PATCH 3/3] dt: binding documentation for bq2415x charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131125130700.GC21526@amd.pavel.ucw.cz>
Date:	Mon, 25 Nov 2013 14:07:00 +0100
From:	Pavel Machek <pavel@....cz>
To:	Sebastian Reichel <sre@...ian.org>
Cc:	Sebastian Reichel <sre@...g0.de>,
	Anton Vorontsov <anton@...msg.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Landley <rob@...dley.net>, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
	Pali Rohár <pali.rohar@...il.com>,
	freemangordon@....bg, aaro.koskinen@....fi
Subject: Re: [PATCH 3/3] dt: binding documentation for bq2415x charger

On Sun 2013-11-24 17:49:31, Sebastian Reichel wrote:
> Add devicetree binding documentation for bq2415x charger.
> 
> Signed-off-by: Sebastian Reichel <sre@...ian.org>

Thanks!

> +- reg: integer, i2c address of the device
> +- ti,current-limit: integer, current limit in mA

Does this need to be "ti," specific? Most of fields are likely to be
needed for other li-ion chargers....

"Specifies maximum current charger can pull from power supply"

?

> +- ti,charge-current: integer, charging current in mA

...why/how is it different from current-limit? Is the current-limit on
5V, while the charge-current relative to battery voltage... so that
charge-current can be > current-limit when battery voltage is low?

"Maximum current that will be supplied to the battery, as determined
by voltage on current sense resistor"?

> +- ti,weak-battery-voltage: integer, weak battery voltage threshold in mV

It would be good to explain what this threshold means. Voltage so low
that system needs to be shut down?

Hmm, it looks to me like it is "as long as battery is below this
voltage, fast charge is not started. Instead, slow 'precharge' is
performed."

> +- ti,battery-regulation-voltage: integer, battery regulation
>  voltage in mV

"Selects maximum voltage for charging."

> +- ti,termination-current: integer, termination current in mA

"When current in constant-voltage phase drops below this value, charge
is terminated".


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/