linux-kernel - [PATCH] mfd: mc13xxx: remove unnecessary spi_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <002601cee98e$44f75210$cee5f630$%han@samsung.com>
Date:	Mon, 25 Nov 2013 12:27:29 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Lee Jones' <lee.jones@...aro.org>
Cc:	linux-kernel@...r.kernel.org,
	'Samuel Ortiz' <sameo@...ux.intel.com>,
	'Jingoo Han' <jg1.han@...sung.com>,
	'Uwe Kleine-König' 
	<u.kleine-koenig@...gutronix.de>,
	'Marc Reilly' <marc@...esign.com.au>
Subject: [PATCH] mfd: mc13xxx: remove unnecessary spi_set_drvdata()

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@...sung.com>
---
 drivers/mfd/mc13xxx-spi.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/mc13xxx-spi.c b/drivers/mfd/mc13xxx-spi.c
index 5f14ef6..cbcc86d 100644
--- a/drivers/mfd/mc13xxx-spi.c
+++ b/drivers/mfd/mc13xxx-spi.c
@@ -149,7 +149,6 @@ static int mc13xxx_spi_probe(struct spi_device *spi)
 		ret = PTR_ERR(mc13xxx->regmap);
 		dev_err(mc13xxx->dev, "Failed to initialize register map: %d\n",
 				ret);
-		spi_set_drvdata(spi, NULL);
 		return ret;
 	}
 
-- 
1.7.10.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/