linux-kernel - [REPOST PATCH V2] irq: enable all irqs unconditionally in irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1385388587-16442-1-git-send-email-ldewangan@nvidia.com>
Date:	Mon, 25 Nov 2013 19:39:47 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	<tglx@...utronix.de>
CC:	<linux-kernel@...r.kernel.org>, <ian.campbell@...rix.com>,
	<rjw@...ysocki.net>, <len.brown@...el.com>,
	<gregkh@...uxfoundation.org>, <linux-pm@...r.kernel.org>,
	<heiko@...ech.de>, <pavel@....cz>,
	Laxman Dewangan <ldewangan@...dia.com>
Subject: [REPOST PATCH V2] irq: enable all irqs unconditionally in irq_resume

When system enters into suspend, it disable all irqs in single
function call. This disables EARLY_RESUME irqs also along with
normal irqs.

The EARLY_RESUME irqs get enabled in sys_core_ops->resume and
non-EARLY_RESUME irqs get enabled in normal system resume path.

When suspend_noirq failed or suspend is aborted for any reason,
the EARLY_RESUME irqs do not get enabled as sys_core_ops->resume()
call did not happen. It only enables the non-EARLY_RESUME irqs in normal
disable for remaining life of system.

Enable all irqs unconditionally in normal irq_resume() regardless of
EARLY_RESUME irqs have been already enabled or not.

Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
Acked-by-and-tested-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Acked-by: Heiko Stuebner <heiko@...ech.de>
Reviewed-by: Pavel Machek <pavel@....cz>

---
Creating this patch based on disucssion on patch
 [PATCH] irq: enable suspended EARLY_RESUME irqs forcefully if not resumed

Making simple change as susggested by Thomas.

Reposting it with ack and review.

 kernel/irq/pm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
index cb228bf..abcd6ca 100644
--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -50,7 +50,7 @@ static void resume_irqs(bool want_early)
 		bool is_early = desc->action &&
 			desc->action->flags & IRQF_EARLY_RESUME;

-		if (is_early != want_early)
+		if (!is_early && want_early)
 			continue;

 		raw_spin_lock_irqsave(&desc->lock, flags);
-- 
1.7.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/