linux-kernel - Re: [PATCH 0/4] thinkpad_acpi: Add support for controlling charge thresholds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131125145958.GA13564@jak-x230>
Date:	Mon, 25 Nov 2013 15:59:58 +0100
From:	Julian Andres Klode <jak@...-linux.org>
To:	Julian Andres Klode <jak@...-linux.org>
Cc:	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	Matthew Garrett <matthew.garrett@...ula.com>,
	"open list:THINKPAD ACPI EXT..." 
	<ibm-acpi-devel@...ts.sourceforge.net>,
	"open list:THINKPAD ACPI EXT..." 
	<platform-driver-x86@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/4] thinkpad_acpi: Add support for controlling charge
 thresholds

On Mon, Nov 11, 2013 at 02:56:29PM +0100, Julian Andres Klode wrote:
> This patch series adds support for specifying charging thresholds,
> forcing a battery to discharge, and inhibiting charging, on ThinkPad
> Laptops using Sandy Bridge or newer processors.
> 
> The first two patches should be stable now, the third one does not work on
> my test system (but I'd appreciate if anyone with something other than an
> X230 tests it). 
> 
> The inhibit charging part is a bit unprecise, and I can obviously not test
> that -1 really means permanently, but I assume it does. I don't know whether
> this one should be merged.
> 
> Changes since the RFC PATCH:
>   - Define batteries more dynamically instead of statically using large
>     macros. Added support for up to 3 batteries, unsupported ones will not
>     be exported.
>   - Added 3 more new patches with more features
> 
> Julian Andres Klode (4):
>   thinkpad_acpi: Add support for controlling charge thresholds
>   thinkpad_acpi: battery: Add force_discharge attribute
>   thinkpad_acpi: battery: Add force_discharge_ac_break attribute
>   thinkpad_acpi: battery: Add inhibit_charge_minutes attribute
> 
>  Documentation/laptops/thinkpad-acpi.txt |  37 ++++
>  drivers/platform/x86/thinkpad_acpi.c    | 300 ++++++++++++++++++++++++++++++++
>  2 files changed, 337 insertions(+)
> 

I'd really like to get some comments on this series (especially by Henrique
and Matthew, they're responsible); so I know what I have to fix and whether
I should drop some of the later patches, and if the patch series has any
chance of being accepted...

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Please do not top-post if possible.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/