linux-kernel - Re: [GIT PULL] ima: bug fixes for Linus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.02.1311260235020.9714@tundra.namei.org>
Date:	Tue, 26 Nov 2013 02:40:49 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
cc:	linux-security-module <linux-security-module@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] ima: bug fixes for Linus

On Mon, 25 Nov 2013, Mimi Zohar wrote:

> Hi James,
> 
> These are the "essential fixes for regressions".
> 
> The following changes since commit 4c1cc40a2d49500d84038ff751bc6cd183e729b5:
> 
>   Revert "KEYS: verify a certificate is signed by a 'trusted' key" (2013-11-23 16:38:17 -0800)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity for-linus
> 
> for you to fetch changes up to 72ca1bd303a5126d0ce377cff699282b6b38bd86:
> 
>   ima: make a copy of template_fmt in template_desc_init_fields() (2013-11-25 07:32:46 -0500)
> 
> thanks,
> 
> Mimi
> 
> ----------------------------------------------------------------
> Roberto Sassu (3):

>       ima: make a copy of template_fmt in template_desc_init_fields()


> template_desc_init_fields(char *template_fmt,

That should probably be const char.

Also, the call to kstrdup() results in a memory leak.





-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/