linux-kernel - Re: [PATCH] staging: slicoss: fix possible missing iounmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131125202859.GA29969@kroah.com>
Date:	Mon, 25 Nov 2013 12:28:59 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Laurent Navet <laurent.navet@...il.com>
Cc:	devel@...verdev.osuosl.org, peter.p.waskiewicz.jr@...el.com,
	linux-kernel@...r.kernel.org, rashika.kheria@...il.com,
	cruzjbishop@...il.com
Subject: Re: [PATCH] staging: slicoss: fix possible missing iounmap

On Fri, Nov 15, 2013 at 11:30:07PM +0100, Laurent Navet wrote:
> if slic_card_locate failed, memmapped_ioaddr is not unmapped.
> 
> Signed-off-by: Laurent Navet <laurent.navet@...il.com>
> ---
>  drivers/staging/slicoss/slicoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This patch causes a build warning to be added to the system, implying
that you didn't even test-build this patch :(

Sorry, I can't take this as-is for this obvious reason.

Please fix this up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/