linux-kernel - Re: randconfig build error in next-20131125, in drivers/video/kyro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXGXKUHw8jVrn-_n0Y9QPaWA5hQ9Mim+W1t+-LGezuh3A@mail.gmail.com>
Date:	Mon, 25 Nov 2013 21:46:04 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Jim Davis <jim.epost@...il.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Linux-Next <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	Linux Fbdev development list <linux-fbdev@...r.kernel.org>
Subject: Re: randconfig build error in next-20131125, in drivers/video/kyro

On Mon, Nov 25, 2013 at 8:49 PM, Jim Davis <jim.epost@...il.com> wrote:
> /home/jim/linux/arch/x86/include/asm/uaccess.h: In function ‘kyrofb_ioctl’:
> /home/jim/linux/arch/x86/include/asm/uaccess.h:633: error: call to
> ‘copy_to_user_overflow’ declared with attribute error: copy_to_user()
> buffer size is too small

Cool!

        case KYRO_IOCTL_UVSTRIDE:
                if (copy_to_user(argp, &deviceInfo.ulOverlayUVStride,
sizeof(unsigned long)))

ulOverlayUVStride is u32, while unsigned long is 8 bytes on 64 bit.

I guess it should use "sizeof(u32)", or better
"sizeof(deviceInfo.ulOverlayUVStride)"
instead.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/