linux-kernel - Re: [PATCH 08/16] staging/lustre/mdt: HSM coordinator agent interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131126033012.GA30128@kroah.com>
Date:	Mon, 25 Nov 2013 19:30:12 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Peng Tao <bergwolf@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	JC Lafoucriere <jacques-charles.lafoucriere@....fr>,
	Andreas Dilger <andreas.dilger@...el.com>
Subject: Re: [PATCH 08/16] staging/lustre/mdt: HSM coordinator agent interface

On Tue, Nov 26, 2013 at 10:05:02AM +0800, Peng Tao wrote:
> From: JC Lafoucriere <jacques-charles.lafoucriere@....fr>
> 
> To move data with external storage, HSM coordinator
> uses a Copy Tool running on a client named agent.
> This patch implements the interface for these agents.

Interesting text here...

> Lustre-change: http://review.whamcloud.com/6534
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3342
> Signed-off-by: JC Lafoucriere <jacques-charles.lafoucriere@....fr>
> Reviewed-by: Jinshan Xiong <jinshan.xiong@...el.com>
> Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>
> Reviewed-by: John L. Hammond <john.hammond@...el.com>
> Reviewed-by: Oleg Drokin <oleg.drokin@...el.com>
> Signed-off-by: Peng Tao <bergwolf@...il.com>
> Signed-off-by: Andreas Dilger <andreas.dilger@...el.com>
> ---
>  .../lustre/lustre/include/lustre/lustre_user.h     |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
> index 9436166..631f026 100644
> --- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
> +++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
> @@ -428,8 +428,8 @@ struct obd_uuid {
>  	char uuid[UUID_MAX];
>  };
>  
> -static inline int obd_uuid_equals(const struct obd_uuid *u1,
> -				  const struct obd_uuid *u2)
> +static inline bool obd_uuid_equals(const struct obd_uuid *u1,
> +				   const struct obd_uuid *u2)
>  {
>  	return strcmp((char *)u1->uuid, (char *)u2->uuid) == 0;
>  }
> @@ -446,7 +446,7 @@ static inline void obd_str2uuid(struct obd_uuid *uuid, const char *tmp)
>  }
>  
>  /* For printf's only, make sure uuid is terminated */
> -static inline char *obd_uuid2str(struct obd_uuid *uuid)
> +static inline char *obd_uuid2str(const struct obd_uuid *uuid)
>  {
>  	if (uuid->uuid[sizeof(*uuid) - 1] != '\0') {
>  		/* Obviously not safe, but for printfs, no real harm done...

Too bad it doesn't describe the changes made in the code at all.

How can so many people review a patch that is not the same as what it
says it really is?

I'm stopping here in the series, sorry.  Please fix up and resend the
rest when you can.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/