linux-kernel - RE: [V3 01/10] perf: New conditional branch filter criteria in branch stack sampling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131126060618.917ED2C00A9@ozlabs.org>
Date:	Tue, 26 Nov 2013 17:06:18 +1100 (EST)
From:	michael@...abs.org (mpe@...erman.id.au)
To:	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Cc:	mikey@...ling.org, sukadev@...ux.vnet.ibm.com,
	michaele@....ibm.com, eranian@...gle.com
Subject: RE: [V3 01/10] perf: New conditional branch filter criteria in branch stack sampling

Ideally your commit subject would contain a verb, preferably in the present
tense.

I think simply "perf: Add PERF_SAMPLE_BRANCH_COND" would be clearer.

On Wed, 2013-16-10 at 06:56:48 UTC, Anshuman Khandual wrote:
> POWER8 PMU based BHRB supports filtering for conditional branches.
> This patch introduces new branch filter PERF_SAMPLE_BRANCH_COND which
> will extend the existing perf ABI. Other architectures can provide
> this functionality with either HW filtering support (if present) or
> with SW filtering of instructions.
> 
> Signed-off-by: Anshuman Khandual <khandual@...ux.vnet.ibm.com>
> Reviewed-by: Stephane Eranian <eranian@...gle.com>
> ---
>  include/uapi/linux/perf_event.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index 0b1df41..5da52b6 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -160,8 +160,9 @@ enum perf_branch_sample_type {
>  	PERF_SAMPLE_BRANCH_ABORT_TX	= 1U << 7, /* transaction aborts */
>  	PERF_SAMPLE_BRANCH_IN_TX	= 1U << 8, /* in transaction */
>  	PERF_SAMPLE_BRANCH_NO_TX	= 1U << 9, /* not in transaction */
> +	PERF_SAMPLE_BRANCH_COND		= 1U << 10, /* conditional branches */
>  
> -	PERF_SAMPLE_BRANCH_MAX		= 1U << 10, /* non-ABI */
> +	PERF_SAMPLE_BRANCH_MAX		= 1U << 11, /* non-ABI */
>  };

This no longer applies against Linus' tree, you'll need to rebase it.

cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/