linux-kernel - Re: [PATCH] ARM: dts: omap3-beagle: Fix USB host on beagle boards (for 3.13)

Open Source and information security mailing list archives

Message-ID: <52946243.70903@ti.com>
Date:	Tue, 26 Nov 2013 10:56:35 +0200
From:	Roger Quadros <rogerq@...com>
To:	Nishanth Menon <nm@...com>
CC:	Tony Lindgren <tony@...mide.com>,
	Benoit Cousson <bcousson@...libre.com>,
	dt list <devicetree@...r.kernel.org>,
	<linux-usb@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org>,
	<balbi@...com>, linux-omap <linux-omap@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: omap3-beagle: Fix USB host on beagle boards
 (for 3.13)

On 11/25/2013 05:50 PM, Nishanth Menon wrote:
> On Mon, Nov 25, 2013 at 7:55 AM, Roger Quadros <rogerq@...com> wrote:
>> Beagle (rev. C4) and Beagle-XM (all revs) need VAUX2 1.8V supply
>> for the USB PHY.
>>
>> As the generic PHY driver can't handle more than one supply
>> at the moment, we configure this supply to be always on.
>> This will cause a very small power impact if the USB host subsystem
>> is not in use, about 76.86 micro-W + LDO power.
> 
>>
>> Older Beagle boards (prior to C4) don't have VAUX2 connected anywhere,
>> so there won't be any functional impact on those boards other than
>> some additional LDO power consumption.
>>
>> Reported-by: Nishanth Menon <nm@...com>
>> Signed-off-by: Roger Quadros <rogerq@...com>
> 
> Tested-by: Nishanth Menon <nm@...com>

Thanks Nishant.
> 
> I might suggest though that the better alternative might be to get phy
> driver to handle multiple regulators considering that DT is supposed
> to represent the h/w topology.

Noted. I will work on this for 3.14.

cheers,
-roger

> 
>> ---
>>  arch/arm/boot/dts/omap3-beagle-xm.dts | 8 ++++++++
>>  arch/arm/boot/dts/omap3-beagle.dts    | 8 ++++++++
>>  2 files changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
>> index 31a632f..b39918e 100644
>> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
>> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
>> @@ -215,3 +215,11 @@
>>  &usbhsehci {
>>         phys = <0 &hsusb2_phy>;
>>  };
>> +
>> +&vaux2 {
>> +       regulator-name = "usb_1v8";
>> +       regulator-min-microvolt = <1800000>;
>> +       regulator-max-microvolt = <1800000>;
>> +       regulator-always-on;
>> +};
>> +
>> diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts
>> index fa532aa..9764556 100644
>> --- a/arch/arm/boot/dts/omap3-beagle.dts
>> +++ b/arch/arm/boot/dts/omap3-beagle.dts
>> @@ -178,3 +178,11 @@
>>         mode = <3>;
>>         power = <50>;
>>  };
>> +
>> +&vaux2 {
>> +       regulator-name = "vdd_ehci";
>> +       regulator-min-microvolt = <1800000>;
>> +       regulator-max-microvolt = <1800000>;
>> +       regulator-always-on;
>> +};
>> +
>> --
>> 1.8.3.2
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives