linux-kernel - Re: [PATCH] regulator: core: Use postcore_initcall(regulator_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131126004603.GU14725@sirena.org.uk>
Date:	Tue, 26 Nov 2013 00:46:03 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Fabio Estevam <festevam@...il.com>
Cc:	shawn.guo@...aro.org, linux-kernel@...r.kernel.org,
	thierry.reding@...il.com,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] regulator: core: Use
 postcore_initcall(regulator_init_complete)

On Mon, Nov 25, 2013 at 07:57:35PM -0200, Fabio Estevam wrote:

> Calling regulator_init_complete via late_initcall can be too 'late' for the 
> regulator to be available for the pwm backlight driver.

> Call regulator_init_complete with postcore_initcall level instead.

That's too early for some of the other functionality in this function
though - I'd be particularly worried about the code that goes aroud
turning off unused supplies running before drivers have a chance to load
either breaking things or causing user visible glitches (and of course
the goal here is to get have this run before that happens...).

I seem to remember that there's also some one initcall per object
limitation so if we are going to try to dance this dance purely in the
regulator code it'd probably need to be split out into another object as
well as another function.  The other options that were suggested were to
either have the DT code push out the announcement or change the callers
to check of_have_populated_dt() as well as looking at the flag, of this
lot changing the callers is probably the cleanest.  I'll probably do
that tomorrow if a patch doesn't turn up before then.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)