linux-kernel - Re: [PATCH] perf tools: Fix tags target rebuilding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131126113108.GE2410@gmail.com>
Date:	Tue, 26 Nov 2013 12:31:08 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Mike Galbraith <efault@....de>,
	Stephane Eranian <eranian@...gle.com>,
	David Ahern <dsahern@...il.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH] perf tools: Fix tags target rebuilding


* Jiri Olsa <jolsa@...hat.com> wrote:

> Once the tags file is generated it's never rebuilt
> until it's removed by hand.
> 
> The reason is that the Makefile does not treat tags
> as a target but as a file to be rebuilt.
> 
> Adding tags as PHONY target into the Makefile.
> 
> Signed-off-by: Jiri Olsa <jolsa@...hat.com>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Mike Galbraith <efault@....de>
> Cc: Stephane Eranian <eranian@...gle.com>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  tools/perf/Makefile | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 4835618..95f5792 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -61,7 +61,7 @@ endef
>  #
>  # Needed if no target specified:
>  #
> -all:
> +all tags:

Obviously the change invalidates the comment above.

>  	$(print_msg)
>  	$(make)
>  
> @@ -77,3 +77,5 @@ clean:
>  %:
>  	$(print_msg)
>  	$(make)
> +
> +.PHONY: tags

Note that there's also a TAGS file that uses etags - which probably 
needs similar treatment.

Also note that we have duplicate code for this in Makefile.perf 
already. Would it be possible to pass through this there and keep the 
main Makefile is just a thin, minimal wrapper that adds default 
parallelism, etc?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/