linux-kernel - Re: [PATCH 2/2] framebuffer: Fix int cast to pointer warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5294B558.6030106@ti.com>
Date:	Tue, 26 Nov 2013 16:51:04 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Joe Perches <joe@...ches.com>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] framebuffer: Fix int cast to pointer warnings

On 2013-09-20 06:10, Joe Perches wrote:
> Casts of int to pointer need additional casts to (unsigned long)
> when compiled for x86-64 to silence the compiler.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/video/arkfb.c    | 2 +-
>  drivers/video/vt8623fb.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/arkfb.c b/drivers/video/arkfb.c
> index b13f3f2..26fd4e4 100644
> --- a/drivers/video/arkfb.c
> +++ b/drivers/video/arkfb.c
> @@ -1016,7 +1016,7 @@ static int ark_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>  
>  	pcibios_bus_to_resource(dev, &vga_res, &bus_reg);
>  
> -	par->state.vgabase = (void __iomem *) vga_res.start;
> +	par->state.vgabase = (void __iomem *)(unsigned long)vga_res.start;
>  
>  	/* FIXME get memsize */
>  	regval = vga_rseq(par->state.vgabase, 0x10);
> diff --git a/drivers/video/vt8623fb.c b/drivers/video/vt8623fb.c
> index 7e97c53..281d41b 100644
> --- a/drivers/video/vt8623fb.c
> +++ b/drivers/video/vt8623fb.c
> @@ -731,7 +731,7 @@ static int vt8623_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>  
>  	pcibios_bus_to_resource(dev, &vga_res, &bus_reg);
>  
> -	par->state.vgabase = (void __iomem *) vga_res.start;
> +	par->state.vgabase = (void __iomem *)(unsigned long)vga_res.start;
>  
>  	/* Find how many physical memory there is on card */
>  	memsize1 = (vga_rseq(par->state.vgabase, 0x34) + 1) >> 1;

What's the warning? I'm not seeing anything on my machine when compiling
these two.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)