linux-kernel - Re: [PATCH 21/25] perf evsel: Skip ignored symbols while printing callchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131126161852.GC7775@gmail.com>
Date:	Tue, 26 Nov 2013 17:18:52 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	David Ahern <dsahern@...il.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 21/25] perf evsel: Skip ignored symbols while printing
 callchain


* Arnaldo Carvalho de Melo <acme@...stprotocols.net> wrote:

> Em Tue, Nov 26, 2013 at 07:30:02AM -0700, David Ahern escreveu:
> > On 11/26/13, 7:20 AM, Arnaldo Carvalho de Melo wrote:
> > >Em Tue, Nov 26, 2013 at 12:52:21PM +0200, Adrian Hunter escreveu:
> > >>On 25/11/13 16:17, Arnaldo Carvalho de Melo wrote:
> > >>>From: David Ahern <dsahern@...il.com>
> > >>>  	} else {
> > >>>+		if (al.sym->ignore)
> 
> > >>Seems to segfault here because sym is null
> 
> > >>>+			return;
> 
> > >Changed it to look at (al.sym && al.sym->ignore), the rest of the code
> > >already checkfs if al.sym is NULL (printing [unknown], etc), can you
> > >please take a look at:
> 
> > >https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=c0dd57452349779e0e5d436db8f9448dfffcc512
> 
> > >In an updated acme/perf/core branch?
>  
> > Looks good to me. That's what I was going to send you. Sorry for the noise.
> 
> No problem, I'll regenerate a +perf-core-for-mingo signed tag and 
> send it with this new version with a [PATCH N/M v2] together with a 
> new set of patches that I've put there today, not resending the 
> unmodified patches from last pull req.
> 
> Is that ok with you Ingo?

Sounds good to me!

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/