lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJvTdKm8bcUsnn_=_f_NQzJJ_FgmX6Ch3XDK3un22vwE9_Qh_Q@mail.gmail.com>
Date:	Tue, 26 Nov 2013 13:43:24 -0500
From:	Len Brown <lenb@...nel.org>
To:	Bockholdt Arne <a.bockholdt@...citec-optronik.de>
Cc:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] intel_idle: Fixed C6 state on Avoton/Rangeley processors

>                 .desc = "MWAIT 0x51",
> -               .flags = MWAIT2flg(0x58) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
> +               .flags = MWAIT2flg(0x51) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
>                 .exit_latency = 15,
>                 .target_residency = 45,

Thanks for noticing that .desc and .flags are inconsistent.
This is my fault -- apparently I e-mailed a version of this patch that
is older than what I have in my git tree.

No big issue, though, as 0x51 and 0x58 do exactly the same thing in
AVN hardware.
Indeed, changing .desc to 0x58 would be fine also.

Acked-by: Len Brown <len.brown@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ