linux-kernel - Re: [PATCH v2] mmc: fix host release issue after discard operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fvqig6nl.fsf@octavius.laptop.org>
Date:	Tue, 26 Nov 2013 17:06:06 -0500
From:	Chris Ball <cjb@...top.org>
To:	"Ray Jui" <rjui@...adcom.com>
Cc:	"Seungwon Jeon" <tgih.jun@...sung.com>,
	linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org
Subject: Re: [PATCH v2] mmc: fix host release issue after discard operation

Hi Ray,

On Sat, Oct 26 2013, Ray Jui wrote:
> Under function mmc_blk_issue_rq, after an MMC discard operation,
> the MMC request data structure may be freed in memory. Later in
> the same function, the check of req->cmd_flags & MMC_REQ_SPECIAL_MASK
> is dangerous and invalid. It causes the MMC host not to be released
> when it should
>
> This patch fixes the issue by marking the special request down before
> the discard/flush operation
>
> Reported by: Harold (SoonYeal) Yang <haroldsy@...adcom.com>
> Signed-off-by: Ray Jui <rjui@...adcom.com>
> Reviewed-by: Seungwon Jeon <tgih.jun@...sung.com>

Thanks, pushed to mmc-next for 3.14 and -stable.

- Chris.
-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/