linux-kernel - Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131126235026.GN9468@ld-irv-0074.broadcom.com>
Date:	Tue, 26 Nov 2013 15:50:26 -0800
From:	Brian Norris <computersforpeace@...il.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	dwmw2@...radead.org, wfp5p@...ginia.edu,
	artem.bityutskiy@...ux.intel.com, jg1.han@...sung.com,
	yongjun_wei@...ndmicro.com.cn, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in
 au1550nd_probe()

On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Add missing platform_set_drvdata() in au1550nd_probe(), otherwise
> calling platform_get_drvdata() in remove returns NULL.

An alternative solution: just allocate ctx with devm_kzalloc(). Then you
don't have to kfree() it at all.

I don't mind one solution over the other too much. Let me know which
you'd prefer.

> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/mtd/nand/au1550nd.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/nand/au1550nd.c b/drivers/mtd/nand/au1550nd.c
> index ae8dd7c..909b673 100644
> --- a/drivers/mtd/nand/au1550nd.c
> +++ b/drivers/mtd/nand/au1550nd.c
> @@ -480,6 +480,8 @@ static int au1550nd_probe(struct platform_device *pdev)
>  
>  	mtd_device_register(&ctx->info, pd->parts, pd->num_parts);
>  
> +	platform_set_drvdata(pdev, ctx);
> +

Personally, I'd choose to call platform_set_drvdata() earlier in the
probe routine (e.g., immediately after its allocation), in case we end
up calling platform_get_drvdata() from some sub-routine in the future.

>  	return 0;
>  
>  out3:
> 

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/