linux-kernel - Re: [PATCH 17/22] perf tools: Add build and install plugins targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vbzeqn25.fsf@sejong.aot.lge.com>
Date:	Wed, 27 Nov 2013 17:13:54 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 17/22] perf tools: Add build and install plugins targets

Hi Jiri,

On Mon, 25 Nov 2013 15:51:44 +0100, Jiri Olsa wrote:
> On Sat, Nov 23, 2013 at 12:27:48AM +0900, Namhyung Kim wrote:
>> 2013-11-21 (목), 12:01 +0100, Jiri Olsa:
>> > Adding 'plugins' target along with the libtraceevent.a,
>> > so plugins are built together with traceevent library.
>> > 
>> > Adding 'install-traceevent-plugins' Makefile install target,
>> > instructing perf to install plugins into:
>> >   $(HOME)/libexec/perf-core/traceevent/plugins
>> >     - if installed localy under $HOME
>> >   $(DESTDIR)/$(prefix)/$(perfexecdir)/traceevent/plugins
>> >     - if installed globally
>> 
>> [SNIP]
>> > --- a/tools/perf/config/Makefile
>> > +++ b/tools/perf/config/Makefile
>> > @@ -578,6 +578,7 @@ else
>> >  lib = lib
>> >  endif
>> >  libdir = $(prefix)/$(lib)
>> > +plugindir=$(perfexecdir)/traceevent/plugins
>> 
>> Hmm.. it puts traceevent plugins under the perf directory.  But I don't
>> think it's a good idea since libtraceevent can be used independently.
>> 
>> What about something like this?
>> 
>>   plugindir = $(perfexecdir)/../traceevent/plugins
>
> this is where trace-cmd stores them:
>
>   $(HOME)/.trace-cmd/plugins
>   $(prefix)/$(libdir)/trace-cmd/plugins
>
> but I guess we want global place to install plugins,
> the traceevent by default uses:
>
>   $(HOME)/.traceevent/plugins
>   $(prefix)/lib/traceevent/plugins
>
> How about that?

Looks good to me.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/