linux-kernel - Re: [PATCHv2] perf tools: Fix tags/TAGS targets rebuilding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131127113114.GA10495@gmail.com>
Date:	Wed, 27 Nov 2013 12:31:14 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Mike Galbraith <efault@....de>,
	Stephane Eranian <eranian@...gle.com>,
	David Ahern <dsahern@...il.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCHv2] perf tools: Fix tags/TAGS targets rebuilding


* Jiri Olsa <jolsa@...hat.com> wrote:

> On Tue, Nov 26, 2013 at 05:13:16PM +0100, Ingo Molnar wrote:
> 
> SNIP
> 
> > >  
> > >  #
> > >  # Needed if no target specified:
> > > +# (Except for tags and TAGS targets. The reason is that the
> > > +# Makefile does not treat tags/TAGS as targets but as files
> > > +# and thus won't rebuilt them once they are in place.)
> > 
> > s/rebuilt/rebuild
> > 
> > Btw., could we perhaps change the targets to 'ctags' and 'etags' 
> > instead? (That will make it natural to add 'gtags' in the future, 
> > should anyone want that.)
> 
> my fingers vote against removing 'make tags' (and cscope)
> dont care much about the rest though.. ;-)

Okay, fair enough, and 'tags/TAGS' targets is also what the main 
kernel build system uses - so I concur. For your updated v2 patch:

  Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/