| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131127153019.GR3296@lee--X1> Date: Wed, 27 Nov 2013 15:30:19 +0000 From: Lee Jones <lee.jones@...aro.org> To: Stefan Agner <stefan@...er.ch> Cc: swarren@...dotorg.org, thierry.reding@...il.com, sameo@...ux.intel.com, dev@...xeye.de, mark.rutland@....com, linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 1/3] mfd: tps6586x: add version detection On Wed, 27 Nov 2013, Stefan Agner wrote: > Am 2013-11-27 15:36, schrieb Lee Jones: > <snip> > >> Perhaps I should suggest to make TPS6586X_ANY a positive number then, > >> as a negative value to me indicates more of an error than a generic > >> parameter. > I see, its especially confusing since the version is filled using the > i2c_smbus_read_byte_data functions return value. The version field is a > 8-Bit value according to the data sheet, I could use 0x100 as > TPS6586X_ANY identifier. How far are we away from using 0xFF? I'd be happy to use that and change it _if_ we ever get close. If it's likely that it'll be used, then sure 0x100 sounds okay too. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists