linux-kernel - Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131127162859.GD14725@sirena.org.uk>
Date:	Wed, 27 Nov 2013 16:28:59 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Landley <rob@...dley.net>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver for
 Maxim 14577

On Wed, Nov 27, 2013 at 04:13:23PM +0000, Lee Jones wrote:
> On Wed, 27 Nov 2013, Mark Brown wrote:

> > The usual thing to do is of_get_child_by_name() on the parent to get the
> > container to search in.

> What do you mean when you say 'usual thing'? Only the max8998 does
> this currently. IMHO the better way to do it for MFD devices is
> provide a compatible string and let the framework does the rest for
> you.

No, as3722, Palmas and three of the TPS chips do the same thing.  If it
were a purely Linux-internal thing I'd probably agree with you but as it
is we'd just be adding compatible strings in everyone's DTs to save one
line of code in the kernel.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)