linux-kernel - Re: [PATCH 2/2] regulator: core: Check for DT every time we check full constraints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131127165354.GL14725@sirena.org.uk>
Date:	Wed, 27 Nov 2013 16:53:54 +0000
From:	Mark Brown <broonie@...nel.org>
To:	"Jon Medhurst (Tixy)" <tixy@...aro.org>
Cc:	Fabio Estevam <festevam@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>, thierry.reding@...il.com,
	linux-kernel@...r.kernel.org, linaro-kernel@...ts.linaro.org
Subject: Re: [PATCH 2/2] regulator: core: Check for DT every time we check
 full constraints

On Wed, Nov 27, 2013 at 04:32:59PM +0000, Jon Medhurst (Tixy) wrote:

> Doesn't this now make this code in regulator_init_complete()
> redundant..?

> 	if (of_have_populated_dt())
> 		has_full_constraints = true;

Yes, it is a bit redundant now.

> Or is keeping this to avoid one less variable check a worthwhile
> optimisation?

I expect it can be removed, I just wanted to check that the function
wasn't horribly expensive for some silly reason before I actually went
and did that.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)