linux-kernel - Re: [PATCH v2] ACPI: Cleanup <acpi/acpi.h>, <acpi/acpi_bus.h> and <acpi/acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3542568.jpR4FU4Yha@vostro.rjw.lan>
Date:	Wed, 27 Nov 2013 01:29:20 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	boris.ostrovsky@...cle.com, david.vrabel@...rix.com,
	Lv Zheng <lv.zheng@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	"Luck, Tony" <tony.luck@...el.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Len Brown <len.brown@...el.com>, Lv Zheng <zetalog@...il.com>,
	linux-acpi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ACPI: Cleanup <acpi/acpi.h>, <acpi/acpi_bus.h> and <acpi/acpi_drivers.h> inclusions.

On Tuesday, November 26, 2013 03:29:05 PM Konrad Rzeszutek Wilk wrote:
> On Tue, Nov 26, 2013 at 09:29:33PM +0100, Rafael J. Wysocki wrote:
> > On Tuesday, November 26, 2013 01:21:15 PM Lv Zheng wrote:
> > > Replace direct inclusions of <acpi/acpi.h>, <acpi/acpi_bus.h> and
> > > <acpi/acpi_drivers.h>, which are incorrect, with <linux/acpi.h> inclusions.
> > > 
> > > First of all, <acpi/acpi.h>, <acpi/acpi_bus.h> and <acpi/acpi_drivers.h>
> > > should not be included directly from any files that are built for
> > > CONFIG_ACPI unset, because that generally leads to build warnings about
> > > undefined symbols in !CONFIG_ACPI builds.  For CONFIG_ACPI set,
> > > <linux/acpi.h> includes those files and for !CONFIG_ACPI it provides stub
> > > ACPI symbols to be used in that case.
> > > 
> > > Second, there are ordering dependencies between those files that always
> > > have to be met.  Namely, it is required that <acpi/acpi_bus.h> be included
> > > prior to <acpi/acpi_drivers.h> so that the acpi_pci_root declarations the
> > > latter depends on are always there.  And <acpi/acpi.h> which provides
> > > basic ACPICA type declarations should always be included prior to any other
> > > ACPI headers in CONFIG_ACPI builds.  That also is taken care of including
> > > <linux/acpi.h> as appropriate.
> > > 
> > > This patch also includes necessary cleanups in the affected files where
> > > other ACPI headers is also included but not referenced.
> > >
> > 
> > This looks OK to me, but it touches several other subsystems.  It's better to
> > CC such things to linux-kernel at least.
> > 
> > Peter, Matthew, Tony, Konrad, Greg, Bjorn, do you have any objections against this?
> 
> CC-ing Boris and David here.
> 
> I presume the proper compilation tests to make sure they do compile properly
> has been done.

Yes and we're going to run it through the auto build machinery anyway.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/