linux-kernel - Re: [PATCH] dmaengine: pl08x: fix conversioin for generic unmap data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4js+Hq+b8g1i65NE8iK-BnXjG9Bi3PuPpWXRss19-Z9Jg@mail.gmail.com>
Date:	Wed, 27 Nov 2013 11:38:48 -0800
From:	Dan Williams <dan.j.williams@...el.com>
To:	Olof Johansson <olof@...om.net>
Cc:	Vinod Koul <vinod.koul@...el.com>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: pl08x: fix conversioin for generic unmap data

Thanks, Olof I'll push this shortly.  I'll add your acked-by to this
one from Russell.

https://patchwork.kernel.org/patch/3241941/

--
Dan

On Tue, Nov 26, 2013 at 8:53 PM, Olof Johansson <olof@...om.net> wrote:
> commit d38a8c622a1b ('dmaengine: prepare for generic 'unmap' data')
> added a generic unmap call but used the wrong argument for it. Fix it.
>
> Fixes: d38a8c622a1b ('dmaengine: prepare for generic 'unmap' data')
> Signed-off-by: Olof Johansson <olof@...om.net>
> ---
>
> I can't actually tell what the intent of d38a8cc622a1b and how mappings
> are expected to be managed, but it's obviously passing the wrong thing
> in here so it seems like the appropriate fix.
>
>  drivers/dma/amba-pl08x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index 16a2aa28f856..ec4ee5c1fe9d 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -1169,7 +1169,7 @@ static void pl08x_desc_free(struct virt_dma_desc *vd)
>         struct pl08x_txd *txd = to_pl08x_txd(&vd->tx);
>         struct pl08x_dma_chan *plchan = to_pl08x_chan(vd->tx.chan);
>
> -       dma_descriptor_unmap(txd);
> +       dma_descriptor_unmap(&vd->tx);
>         if (!txd->done)
>                 pl08x_release_mux(plchan);
>
> --
> 1.8.4.1.601.g02b3b1d
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/