linux-kernel - Re: [PATCH] PCI: Clear Bus Master bit only on kexec reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131127195317.GA13028@srcf.ucam.org>
Date:	Wed, 27 Nov 2013 19:53:17 +0000
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Khalid Aziz <khalid.aziz@...cle.com>
Cc:	bhelgaas@...gle.com, cl91tp@...il.com, tianyu.lan@...el.com,
	khlebnikov@...nvz.org, gnomes@...rguk.ukuu.org.uk,
	indou.takao@...fujitsu.com, jility09@...il.com, f.otti@....at,
	ebiederm@...ssion.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, kexec@...ts.infradead.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] PCI: Clear Bus Master bit only on kexec reboot

On Wed, Nov 27, 2013 at 12:48:42PM -0700, Khalid Aziz wrote:

> I debated between pci.h and kexec.h but pci-driver.c does not
> include kexec.h and I didn't want to include a whole new file. Now I
> see another problem with adding that extern declaration to pci.h -
> if CONFIG_KEXEC is not set, build will fail. I should add #ifdef
> CONFIG_KEXEC to the code in pci-driver.c as well. Time for v2.

You're making the behaviour of the pci code conditional on whether we're 
in kexec or not, so I think adding kexec.h is perfectly reasonable.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/