linux-kernel - Re: [PATCH] PCI: Clear Bus Master bit only on kexec reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131127220106.GA21887@kroah.com>
Date:	Wed, 27 Nov 2013 14:01:06 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Khalid Aziz <khalid.aziz@...cle.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>, bhelgaas@...gle.com,
	cl91tp@...il.com, tianyu.lan@...el.com, khlebnikov@...nvz.org,
	gnomes@...rguk.ukuu.org.uk, indou.takao@...fujitsu.com,
	jility09@...il.com, f.otti@....at, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, kexec@...ts.infradead.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] PCI: Clear Bus Master bit only on kexec reboot

On Wed, Nov 27, 2013 at 09:53:09PM +0000, Matthew Garrett wrote:
> On Wed, Nov 27, 2013 at 01:22:27PM -0800, Greg KH wrote:
> 
> > Then fix the drivers please.  It's not as if you don't have access to
> > the source for them all...
> 
> Define "fix". It's clearly wrong to disable busmastering at shutdown on 
> some devices, otherwise we wouldn't be having this discussion at all.

I thought it was only "wrong" to disable this on multi-function devices,
which is why some drivers didn't do it.  Otherwise, how would it be any
different to have the global setting?

Anyway, I really don't care either way, but this seems like something
that the drivers should be doing.  What suddenly changed that caused
this problem to occur that hasn't happened in the years prior to now
that drives this to be a stable-kernel issue?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/