linux-kernel - Re: [PATCH] UAPI linux/fs.h: add a warning about wrong ioctl argument types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131127230207.GF29912@hall.aurel32.net>
Date:	Thu, 28 Nov 2013 00:02:07 +0100
From:	Aurelien Jarno <aurelien@...el32.net>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-kernel@...r.kernel.org,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Theodore Ts'o <tytso@....edu>, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] UAPI linux/fs.h: add a warning about wrong ioctl
 argument types

On Wed, Nov 27, 2013 at 03:13:40AM -0800, Christoph Hellwig wrote:
> Thanks Aurelien,
> 
> the added comment looks good and very useful,
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 

Thanks for the review.

> We don't have any man pages documenting these ioctls or other user
> visible documentation, do we?

The only documentation I have found about these ioctls is from the
ioctl_list(2) manpage, but with different name and defined in
<linux/ext2_fs.h>. In any case they are correctly defined:

       0x80046601   EXT2_IOC_GETFLAGS     int *
       0x40046602   EXT2_IOC_SETFLAGS     const int *
       0x80047601   EXT2_IOC_GETVERSION   int *
       0x40047602   EXT2_IOC_SETVERSION   const int *

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@...el32.net                 http://www.aurel32.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/