linux-kernel - Re: [PATCH v2] cpufreq: exynos: Convert exynos-cpufreq to platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK9yfHwzgmWxA2pOpHa0O0C8+zUGOxvH5jrNBM4bYEMiM8N2jQ@mail.gmail.com>
Date:	Thu, 28 Nov 2013 17:10:39 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Lukasz Majewski <l.majewski@...sung.com>
Cc:	Viresh Kumar <viresh.kumar@...aro.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>,
	Linux PM list <linux-pm@...r.kernel.org>,
	Jingoo Han <jg1.han@...sung.com>,
	Lukasz Majewski <l.majewski@...ess.pl>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Tomasz Figa <t.figa@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH v2] cpufreq: exynos: Convert exynos-cpufreq to platform driver

Hi Lukasz,

On 28 November 2013 17:05, Lukasz Majewski <l.majewski@...sung.com> wrote:
> To make the driver multiplatform-friendly, unconditional initialization
> in an initcall is replaced with a platform driver probed only if
> respective platform device is registered.
>
> Tested at: Exynos4210 (TRATS) and Exynos4412 (TRATS2)
>
> Signed-off-by: Lukasz Majewski <l.majewski@...sung.com>
> Signed-off-by: Tomasz Figa <t.figa@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
>
> ---
> Changes for v2:
> - Proper definition of exynos_cpufreq_init() function to squash warnings

Looks good. Just one minor nit which I forgot to mention earlier.

[snip]

>
> -static int __init exynos_cpufreq_init(void)
> +static int exynos_cpufreq_init(struct platform_device *pdev)

How about renaming this function to exynos_cpufreq_probe?

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/