linux-kernel - Re: [PATCH 34/34] perf tools unwinding: Use the per-feature check flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131128125619.GA12292@ghostprotocols.net>
Date:	Thu, 28 Nov 2013 09:56:19 -0300
From:	Arnaldo Carvalho de Melo <acme@...radead.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Jean Pihet <jean.pihet@...aro.org>,
	Will Deacon <will.deacon@....com>,
	linaro-kernel@...ts.linaro.org, patches@...aro.org
Subject: Re: [PATCH 34/34] perf tools unwinding: Use the per-feature check
 flags

Em Thu, Nov 28, 2013 at 10:58:01AM +0100, Jiri Olsa escreveu:
> On Wed, Nov 27, 2013 at 11:43:23PM +0100, Jiri Olsa wrote:
> > On Wed, Nov 27, 2013 at 05:16:34PM -0300, Arnaldo Carvalho de Melo wrote:
> >   LINK     perf
> > /bin/ld: cannot find -lunwind
> > /bin/ld: cannot find -lunwind-x86_64
> > collect2: error: ld returned 1 exit status
> > make[1]: *** [perf] Error 1
> > make[1]: *** Waiting for unfinished jobs....
> > make: *** [all] Error 2

> > I haven't checked this one.. will do tomorrow
 
> we need to plug libunwind flags/libs only if
> the $(feature-libunwind) is enabled..
 
> NO_LIBUNWIND - user's decision not to link with libunwind or
>                architecture that does not support it
 
> $(feature-libunwind) - if it's actually installed
 
> attached change fixies that for me, feel free to use/merge it

Argh, I used tests/make on one machine where those two patches by Jean
were not applied, then rebased on another, the one I use to submit,
those got included but not tests/make tested, which probably explains
why this got thru :-\

Jean, can you please check that this works for you on ARM too?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/