linux-kernel - Re: [PATCH 02/10] crypto: scatterwalk - Set the chain pointer indication bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131128142130.GC32124@gondor.apana.org.au>
Date:	Thu, 28 Nov 2013 22:21:30 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Tom Lendacky <thomas.lendacky@....com>
Cc:	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/10] crypto: scatterwalk - Set the chain pointer
 indication bit

On Tue, Nov 12, 2013 at 11:46:10AM -0600, Tom Lendacky wrote:
> The scatterwalk_crypto_chain function invokes the scatterwalk_sg_chain
> function to chain two scatterlists, but the chain pointer indication
> bit is not set.  When the resulting scatterlist is used, for example,
> by sg_nents to count the number of scatterlist entries, a segfault occurs
> because sg_nents does not follow the chain pointer to the chained scatterlist.
> 
> Update scatterwalk_sg_chain to set the chain pointer indication bit as is
> done by the sg_chain function.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@....com>

Patch applied.  Thanks!

We should also get rid of the crypto-specific SG helpers since
the generic SG helpers are now available everywhere.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/