linux-kernel - Re: [PATCH]: exec: avoid propagating PF_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131128144714.GV10022@twins.programming.kicks-ass.net>
Date:	Thu, 28 Nov 2013 15:47:14 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Tejun Heo <htejun@...il.com>
Cc:	Oleg Nesterov <oleg@...hat.com>, zhang.yi20@....com.cn,
	lkml <linux-kernel@...r.kernel.org>,
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH]: exec: avoid propagating PF_NO_SETAFFINITY into
 userspace child

On Thu, Nov 28, 2013 at 09:38:48AM -0500, Tejun Heo wrote:
> Hey, Peter.
> 
> On Thu, Nov 28, 2013 at 03:31:45PM +0100, Peter Zijlstra wrote:
> > But the WQ_UNBOUND thingies should be just that and should thus not have
> > the NO_SETAFFINITY flag set because there is no valid reason to have it
> > set.
> > 
> > Regardless of whether the threads are shared between unbound workqueues
> > or not.
> 
> Hah?  No, we do not want to allow userland to be able to set
> affinities on any workqueue workers, period.  That's just inviting
> people to do weirdest things and then reporting things like "crypt
> jobs on some of our 500 machines end up stuck on a single cpu once in
> a while" which will eventually be tracked down to some weird shell
> script setting affinity on workers doing something else.
> 
> We really want to insulate workers and pool operation from userland.
> e.g. unbound workqueues now default to per-NUMA affinity unless
> explicitly told not to, which leads to better overall behavior for
> most workloads.  We do wanna keep those details from userland so that
> they can be improved in the future too.

Bah, windows mentality of we know better.

If they do stupid they get stupid; the only thing we should be concerned
about is correctness, they shouldn't be able to crash the system.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/