linux-kernel - [PATCHv3 3/7] perf tools: Fine tune readn function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131128154350.GB31444@krava.brq.redhat.com>
Date:	Thu, 28 Nov 2013 16:43:50 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	David Ahern <dsahern@...il.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Mike Galbraith <efault@....de>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: [PATCHv3 3/7] perf tools: Fine tune readn function

On Thu, Nov 28, 2013 at 08:19:51AM -0700, David Ahern wrote:
> On 11/28/13, 3:30 AM, Jiri Olsa wrote:
> >@@ -151,21 +152,26 @@ unsigned long convert_unit(unsigned long value, char *unit)
> >  	return value;
> >  }
> >
> >+/*
> >+ * Read exactly 'n' bytes or return an error.
> >+ */
> >  ssize_t readn(int fd, void *buf, size_t n)
> >  {
> >  	void *buf_start = buf;
> >+	size_t left = n;
> >
> >-	while (n) {
> >-		ssize_t ret = read(fd, buf, n);
> >+	while (left) {
> >+		ssize_t ret = read(fd, buf, left);
> >
> >  		if (ret <= 0)
> >  			return ret;
> 
> handle EINTR errors? no need to fail readn if the system call is
> interrupted.

right, how about the v3 below?

thanks,
jirka


---
Added a 'left' variable to make the flow clearer, and added a debug
check for the return value - returning 'n' is more obvious. Also do
not fail on EINTR error.

Added small comment for readn.

Original-patch-by: Ingo Molnar <mingo@...nel.org>
Signed-off-by: Jiri Olsa <jolsa@...hat.com>
Cc: Ingo Molnar <mingo@...nel.org>
Cc: Frederic Weisbecker <fweisbec@...il.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Namhyung Kim <namhyung@...nel.org>
Cc: Mike Galbraith <efault@....de>
Cc: David Ahern <dsahern@...il.com>
Cc: Adrian Hunter <adrian.hunter@...el.com>
Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/util/util.c | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 9440481..f12eada 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -6,6 +6,8 @@
 #endif
 #include <stdio.h>
 #include <stdlib.h>
+#include <linux/kernel.h>
+#include <errno.h>
 
 /*
  * XXX We need to find a better place for these things...
@@ -151,21 +153,26 @@ unsigned long convert_unit(unsigned long value, char *unit)
 	return value;
 }
 
+/*
+ * Read exactly 'n' bytes or return an error.
+ */
 ssize_t readn(int fd, void *buf, size_t n)
 {
 	void *buf_start = buf;
+	size_t left = n;
 
-	while (n) {
-		ssize_t ret = read(fd, buf, n);
+	while (left) {
+		ssize_t ret = read(fd, buf, left);
 
-		if (ret <= 0)
+		if ((ret <= 0) && (errno != EINTR))
 			return ret;
 
-		n -= ret;
-		buf += ret;
+		left -= ret;
+		buf  += ret;
 	}
 
-	return buf - buf_start;
+	BUG_ON((size_t)(buf - buf_start) != n);
+	return n;
 }
 
 size_t hex_width(u64 v)
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/