linux-kernel - Re: [PATCH] gpio: better lookup method for platform GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131128165922.GC2281@intel.com>
Date:	Thu, 28 Nov 2013 18:59:22 +0200
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Alexandre Courbot <acourbot@...dia.com>,
	Rhyland Klein <rklein@...dia.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: better lookup method for platform GPIOs

On Thu, Nov 28, 2013 at 03:45:37PM +0100, Linus Walleij wrote:
> On Thu, Nov 28, 2013 at 9:46 AM, Alexandre Courbot <acourbot@...dia.com> wrote:
> 
> > Change the format of the platform GPIO lookup tables to make them less
> > confusing and improve lookup efficiency.
> >
> > The previous format was a single linked-list that required to compare
> > the device name and function ID of every single GPIO defined for each
> > lookup. Switch that to a list of per-device tables, so that the lookup
> > can be done in two steps, omitting the GPIOs that are not relevant for a
> > particular device.
> >
> > The matching rules are now defined as follows:
> > - The device name must match *exactly*, and can be NULL for GPIOs not
> >   assigned to a particular device,
> > - If the function ID in the lookup table is NULL, the con_id argument of
> >   gpiod_get() will not be used for lookup. However, if it is defined, it
> >   must match exactly.
> > - The index must always match.
> >
> > Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> > ---
> > Let's change this bad design before more users start using it. ;)
> 
> OK given that Mika has based his patches on this I'll request
> that he ACK this and then I'll merge this so that he can put
> this patch at the bottom of his patch stack.
> 
> Mika: requesting ACK.

Alexandre, please check Andy's comments.

Apart from that this looks good to me.

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/