linux-kernel - Re: [PATCH] udp: fix possible seqlock deadlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1385660180.5352.26.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 28 Nov 2013 09:36:20 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	jongman.heo@...sung.com
Cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCH] udp: fix possible seqlock deadlock

On Thu, 2013-11-28 at 09:23 -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> In commit c9e9042994d3 ("ipv4: fix possible seqlock deadlock") I left
> another spot where IP_INC_STATS_BH() was improperly used.
> 
> udp_sendmsg() is called from process context, not from softirq context.
> 
> This was detected by lockdep seqlock support.
> 
> Reported-by: jongman heo <jongman.heo@...sung.com>
> Fixes: 584bdf8cbdf6 ("[IPV4]: Fix "ipOutNoRoutes" counter error for TCP and UDP")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Hannes Frederic Sowa <hannes@...essinduktion.org>
> ---

Scrap this, I'll send a v2 with a complete check.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/