linux-kernel - Re: [PATCH] inet: further fixes of possible seqlock deadlocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131128.181554.1888077442034865299.davem@davemloft.net>
Date:	Thu, 28 Nov 2013 18:15:54 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	eric.dumazet@...il.com, jongman.heo@...sung.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] inet: further fixes of possible seqlock deadlocks

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Thu, 28 Nov 2013 23:19:26 +0100

> I don't really understand why we distinguish between _BH and plain ICMP stat
> calls then.
> 
> The non-_BH versions deactivate interrupts when updating the per-cpu counter.

This level of distinction exists back in the day where we did per-cpu counters
by hand.  We used to have a BH counter and a non-BH counter for each statistic
and it really helped performance wise.

These days most of that may not be so relevant any more.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/