linux-kernel - RE: [PATCH] crypto: remove unnecessary includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1628287275CAA9409F1E349DEF3C6CCE77CB99@039-SN2MPN1-012.039d.mgd.msft.net>
Date:	Fri, 29 Nov 2013 08:49:42 +0000
From:	Cristian Stoica <cristian.stoica@...escale.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] crypto: remove unnecessary includes

>From what I could see there is nothing from those includes that is used inside authenc.c.
The build passes without them.

Cristian S.

> > diff --git a/crypto/authenc.c b/crypto/authenc.c
> > index 1875e70..7d4bfaa 100644
> > --- a/crypto/authenc.c
> > +++ b/crypto/authenc.c
> > @@ -17,11 +17,8 @@
> >  #include <crypto/scatterwalk.h>
> >  #include <linux/err.h>
> >  #include <linux/init.h>
> > -#include <linux/kernel.h>
> >  #include <linux/module.h>
> >  #include <linux/rtnetlink.h>
> > -#include <linux/slab.h>
> > -#include <linux/spinlock.h>
> >
> >  typedef u8 *(*authenc_ahash_t)(struct aead_request *req, unsigned int
> flags);
> 
> Why are these includes unnecessary?
> --
> Email: Herbert Xu <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/