linux-kernel - Re: [PATCHv3 20/29] tools lib traceevent: Remove malloc_or_die from plugin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cj2T-AP45ZSy+Q+_cGzHcm+sr7wpPD4Nu-Ud316hpFHDQ@mail.gmail.com>
Date:	Fri, 29 Nov 2013 10:54:21 +0000
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Steven Rostedt <rostedt@...dmis.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCHv3 20/29] tools lib traceevent: Remove malloc_or_die from plugin_function.c

> Removing malloc_or_die calls from plugin_function.c,
> replacing them and factoring the code with standard
> realloc and error path.

[SNIP]
>
>         if (cpu > cpus) {
> -               if (fstack)
> -                       fstack = realloc(fstack, sizeof(*fstack) * (cpu + 1));
> -               else
> -                       fstack = malloc_or_die(sizeof(*fstack) * (cpu + 1));
> +               fstack = realloc(fstack, sizeof(*fstack) * (cpu + 1));

This code also has same problem..

Thanks,
Namhyung


> +               if (!fstack) {
> +                       warning("could not allocate plugin memory\n");
> +                       return 0;
> +               }
>
>                 /* Account for holes in the cpu count */
>                 for (i = cpus + 1; i <= cpu; i++)
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/