linux-kernel - Re: [PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Nov 2013 13:02:46 +0100
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Alexander Shiyan <shc_work@...l.ru>
CC:	linux-kernel@...r.kernel.org, Evgeniy Polyakov <zbr@...emap.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Shawn Guo <shawn.guo@...aro.org>,
	Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private
 structure

On 11/29/2013 12:56 PM, Alexander Shiyan wrote:
>> On 11/29/2013 12:39 PM, Alexander Shiyan wrote:
>>> Private field "clkdiv" is not used outside "probe", so there are
>>> no reason to keep it in driver.
>>
>> Where's the corresponding clk_disable_unprepare()?
> 
> I do not see any relation "clk_disable_unprepare" with this patch.

Yes right, sorry for the noise.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (260 bytes)