linux-kernel - Re: [PATCH v3 1/4] perf diff: color the Delta column

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 Nov 2013 14:44:10 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Ramkumar Ramachandra <artagnon@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v3 1/4] perf diff: color the Delta column

On Thu, Nov 28, 2013 at 10:54:25PM +0530, Ramkumar Ramachandra wrote:
> Jiri Olsa wrote:
> > these colors are not consistent with colors in baseline,
> > moreover all negative values are shown as red
> >
> > - please check get_percent_color function (used for baseline),
> >   it checks the percentage against following values:
> >
> >   #define MIN_GREEN       0.5
> >   #define MIN_RED         5.0
> 
> That was intentional. If you want colors that are consistent with the
> baseline, what do we do about [4/4], where wdiff numbers can be huge?
> (currently I use [green, red] for [positive, negative] there too)

you're, ratio and wdiff need special treatment..

but I expect delta to be have same colors as baseline
(regardless of the +-)

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/