| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1385744701-9936-1-git-send-email-mpn@google.com> Date: Fri, 29 Nov 2013 18:05:01 +0100 From: Michal Nazarewicz <mpn@...gle.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Chad Williamson <chad@...c.us> Cc: devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: [PATCH] staging: silicom: remove dead code From: Michal Nazarewicz <mina86@...a86.com> bus_info field of struct ethtool_drvinfo is an array thus it always evaluates to true in a boolean context. Therefore operation depending on it being false will never be executed. Signed-off-by: Michal Nazarewicz <mina86@...a86.com> --- drivers/staging/silicom/bpctl_mod.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c index 39dc92a..20325f5 100644 --- a/drivers/staging/silicom/bpctl_mod.c +++ b/drivers/staging/silicom/bpctl_mod.c @@ -135,8 +135,6 @@ static int bp_get_dev_idx_bsf(struct net_device *dev, int *index) else return -EOPNOTSUPP; - if (!drvinfo.bus_info) - return -ENODATA; if (!strcmp(drvinfo.bus_info, "N/A")) return -ENODATA; -- 1.8.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists