linux-kernel - Re: [PATCH 3/3] usb: chipidea: hw_phymode_configure moved before ci_usb_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Nov 2013 00:14:20 -0200
From:	Fabio Estevam <festevam@...il.com>
To:	Chris Ruehl <chris.ruehl@...ys.com.hk>
Cc:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	USB list <linux-usb@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init

Hi Chris,

On Fri, Nov 29, 2013 at 12:08 AM, Chris Ruehl <chris.ruehl@...ys.com.hk> wrote:
> hw_phymode_configure configures the PORTSC registers and allow the
> following phy_inits to operate on the right parameters. This fix a problem
> where the UPLI (ISP1504) could not detected, because the Viewport was not
> available and returns 0's only.
>
> Signed-off-by: Chris Ruehl <chris.ruehl@...ys.com.hk>

I have already fixed this issue. It is in mainline now:

commit 03779f05be6dfc48de99763f6c845a003e1e40f3
Author: Fabio Estevam <fabio.estevam@...escale.com>
Date:   Wed Aug 14 12:43:56 2013 +0300

    usb: chipidea: move hw_phymode_configure() into probe

    Currently hw_phymode_configure() is located inside hw_device_reset(), which
    only called by chipidea udc driver.

    When operating in host mode, we also need to call hw_phymode_configure() in
    order to properly configure the PHY mode, so move this function into probe.

    After this change, USB Host1 port on mx53qsb board is functional.

    Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
    Tested-by: Arnaud Patard <arnaud.patard@...-net.org>
    Reviewed-by: Peter Chen <peter.chen@...escale.com>
    Signed-off-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/