linux-kernel - Re: [PATCH 4/9] random: simplify loop in random

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131129200905.GD3778@thunk.org>
Date:	Fri, 29 Nov 2013 15:09:05 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Greg Price <price@....EDU>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] random: simplify loop in random_read

On Wed, Nov 13, 2013 at 03:07:40AM -0500, Greg Price wrote:
> The loop condition never changes until just before a break, so we
> might as well write it as a constant.  Also since v2.6.33-rc7~40^2~2
> ("random: drop weird m_time/a_time manipulation") we don't do
> anything after the loop finishes, so the 'break's might as well
> return directly.  Some other simplifications.
> 
> The behavior should be identical except that I've changed a debug
> message.
> 
> Cc: "Theodore Ts'o" <tytso@....edu>
> Signed-off-by: Greg Price <price@....edu>

Applied, although I slightly edited the commit description the the
debug message mentioned in the description was removed since the first
version of your patch series, and it wasn't updated as part of the
rebase.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/